-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Set aws.vpc.flow.start timestamp field to ISO8601 format #43390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Set aws.vpc.flow.start timestamp field to ISO8601 format #43390
Conversation
Co-authored-by: Moritz Wiesinger <[email protected]>
@MichaelKatsoulis given that this has been out in the wild for a little while, I think we should put this change behind a featuregate |
…com:MichaelKatsoulis/opentelemetry-collector-contrib into chore/set-timestamp-field-to-iso8601-format
@axw I created a feature gate |
…com:MichaelKatsoulis/opentelemetry-collector-contrib into chore/set-timestamp-field-to-iso8601-format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am lifting my approval until we change to RFC3339
format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR updates the
aws.vpc.flow.start
field type and value format for better standards compliance.Current State:
aws.vpc.flow.start
(integer)1609459200
)Problem:
The field represents the start timestamp of a VPC flow log entry. AWS provides this value as seconds since epoch, but OpenTelemetry semantic conventions don't currently define timestamp fields using this format. The majority of timestamp fields in semconv use either ISO-8601 string format or nanoseconds since epoch.
Solution:
This PR converts the field to:
aws.vpc.flow.start
(string)"2021-01-01T00:00:00.000Z"
)Benefits:
Example:
aws.vpc.flow.start: 1609459200
(int64)aws.vpc.flow.start: "2021-01-01T00:00:00.000Z"
(string)Related Issue